This repository has been archived by the owner on Jul 11, 2024. It is now read-only.
Remove SimpleFlatMapper record mapper from database + test db configurations #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
acmos-is
pushed a commit
to infostellarinc/curiostack
that referenced
this pull request
Feb 14, 2022
… configurations (curioswitch#621)" This reverts commit 5e2c931.
acmos-is
added a commit
to infostellarinc/curiostack
that referenced
this pull request
Feb 25, 2022
… configurations (curioswitch#621)" This reverts commit 5e2c931.
chokoswitch
added a commit
that referenced
this pull request
Mar 12, 2022
* Revert "Remove SimpleFlatMapper record mapper from database + test db configurations (#621)" This reverts commit 5e2c931. * Use org.ow2.asm instead of org.simpleflatmapper.ow2-ams in record mapping * Upgrade log4j to 2.17.1 * Upgrade Java to 17 and Gradle to 7.2 * Upgrade Gradle wrapper Continuation of daf1d56 * Remove jcenter * Revert "Remove jcenter" This reverts commit 21b87a2. * Remove jcenter * Compliant with spotlessCheck The task spotlessApply was run. * Override versions in gradle.properties and update wrapper Co-authored-by: koizumi <[email protected]> Co-authored-by: Colin Farrier <[email protected]> Co-authored-by: acmos-is <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this custom record mapper provides a nice performance boost compared to the default record mapper, it is currently not well-maintained. There seems to be an incompatibility with java 15, which causes fields to return null (see related arnaudroger/SimpleFlatMapper#753)
Also added an override factory method to create a new db context with the
Clockconfigured, for testing of matching timestamps.